Fix mutable default arguments, resource leak, and redundant assignment#13185
Open
jashshah999 wants to merge 1 commit intohuggingface:mainfrom
Open
Fix mutable default arguments, resource leak, and redundant assignment#13185jashshah999 wants to merge 1 commit intohuggingface:mainfrom
jashshah999 wants to merge 1 commit intohuggingface:mainfrom
Conversation
- Replace mutable default lists with None/tuple in _replace_with_gguf_linear, _dequantize_gguf_and_restore_linear, SDCascadeTimestepBlock.__init__, and prepare_extra_kwargs to prevent shared state across calls - Use context manager for open() in load_checkpoint to avoid leaking the file handle - Remove redundant self-assignment (image = image) in load_image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes several latent bugs across the codebase:
Mutable default arguments (shared state across calls):
_replace_with_gguf_linear:modules_to_not_convert=[]->Nonewith guard_dequantize_gguf_and_restore_linear: same patternSDCascadeTimestepBlock.__init__:conds=[]->conds=()prepare_extra_kwargs(3 occurrences):exclude_kwargs=[]->exclude_kwargs=()Resource leak:
model_loading_utils.py:open(checkpoint_file, "rb").read()never closes the file handle; wrapped with a context managerDead code:
loading_utils.py:image = imageself-assignment replaced withpass